Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GBM color format #78

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix GBM color format #78

merged 1 commit into from
Apr 19, 2021

Conversation

HidenoriMatsubayashi
Copy link
Contributor

I fixed the color format value because the value specified in gbm_surface_create was incorrect. I don't know why but it worked on RPI4 etc.

See: https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_gbm.txt

Related issues

@HidenoriMatsubayashi HidenoriMatsubayashi added bug Something isn't working drm Topics of DRM backend labels Apr 17, 2021
@HidenoriMatsubayashi
Copy link
Contributor Author

@taka-okayama Will you review this PR?

@taka-okayama
Copy link
Contributor

@HidenoriMatsubayashi

I have a question about pixel format.
Why do you choose GBM_FORMAT_ARGB8888 format? This format has ALPHA component, so this effects alpha blending in every rendering frames. I think GBM_FORMAT_XRGB8888 is a better choice than ARGB such as EGL_MESA_platform_gbm examples.

@HidenoriMatsubayashi
Copy link
Contributor Author

Because Flutter Embedder uses Alpha. See: https://github.com/sony/flutter-embedded-linux/blob/master/src/flutter/shell/platform/linux_embedded/surface/context_egl.cc#L23. Also, Flutter UI planes can overlap with other planes such as Video.

@taka-okayama
Copy link
Contributor

Because Flutter Embedder uses Alpha. See: https://github.com/sony/flutter-embedded-linux/blob/master/src/flutter/shell/platform/linux_embedded/surface/context_egl.cc#L23. Also, Flutter UI planes can overlap with other planes such as Video.

I got. thank you.

@HidenoriMatsubayashi HidenoriMatsubayashi merged commit 0370c49 into sony:master Apr 19, 2021
@HidenoriMatsubayashi HidenoriMatsubayashi deleted the fix-drm-gbm-format-error branch April 19, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taka-okayama taka-okayama taka-okayama approved these changes

Assignees
No one assigned
Labels
bug Something isn't working drm Topics of DRM backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HidenoriMatsubayashi @taka-okayama